[dev] Re: [cvs] commit: imp compose.php imp/templates/compose compose.inc

[Michael M Slusarz]

Quoting Chuck Hagenbuch <chuck@horde.org>:

| What was wrong with leaving the files on the filesystem, or in the VFS,
| and 
| generating everything when sending the message?

Mainly it was an issue of coding clarity and ease of use.  To be honest, I 
had a hell of a hard time trying to figure out how the attachments worked.  
So, instead, I thought that it would be easier to have a single object that 
contained all the information in an easily manipulated form (i.e. MIME_Part 
objects.)

If we don't want to use SessionCache, we could just as easily use a 
HordeTempFile item or something similar.  The new code has two functions 
(_getMimeCache() and _storeMimeCache() I believe) that does all the 
retrieval and storage.  Thus, we can make the changes there without 
affecting the rest of the code.  How about just storing the MIME_Part 
objects in the SessionCache with links to the attachment files - then, we 
we actually send the message, we can import those files into the MIME_Parts 
and delete them?

Mainly, I was just trying to clean up attachment code and get the benefit 
of using MIME_Part objects.  Especially in light of recent messages (e.g. 
we are forwarding message/rfc822 messages in base64 encoding which breaks 
the RFC). this is a stepping off point to resolving those problems.

michael

______________________________________________
Michael Slusarz [slusarz@bigworm.colorado.edu]
The University of Colorado at Boulder