[dev] Re: [cvs] commit: klutz/lib Comic.php klutz/lib/Comic bysize.phpdirect.phpsearch.php

[Marcus I. Ryan]

This message is in MIME format.

---------------------- multipart/mixed attachment
I'm not sure how I feel about that :)

I did it this way mostly because that's how I did it in the PERL
version.  It also feels a little cleaner to me.  It feels more natural
to me to think of sun_url as the sunday URL setting than it does to
think about $comics['shoe']['overrides']['sunday']['url']...
Then again, this method puts more burden on the administrator to
configure it right and thus reduces processing time.  *shrug*

Other opinions on the matter? (user friendly vs. faster)?

Quoting Jon Parise <jon@horde.org>:

> On Mon, Aug 12, 2002 at 02:37:34PM -0700, Marcus I. Ryan wrote:
> 
> > marcus      2002/08/12 14:37:34 PDT
> > 
> >   Modified files:
> >     lib                  Comic.php 
> >     lib/Comic            bysize.php direct.php search.php 
> >   Log:
> >   Add option override capability for a day.  For example, Shoe has
> a different
> >   url on sunday, so we set sun_url => blah, and for a sunday comic
> fetch, it
> >   uses that overriding option.
>    
> Instead of 'sun_url', how about creating an 'overrides' key that
> contains an array of subkeys, e.g.:
> 
>     $foo['overrides'] = array();
>     $foo['overrides']['sunday'] = 'http://...';
> 
> Also, because the days of the week may differ between locales, you
> may
> want to add a note to that effect in the configuration file.
> 
> Neat feature, by the way. =)
> 
> -- 
> Jon Parise (jon@horde.org) :: The Horde Project (http://horde.org/)


-- 
Marcus I. Ryan, marcus@riboflavin.net
-----------------------------------------------------------------------
 "Love is a snowmobile racing across the tundra and then suddenly it
 flips over, pinning you underneath.  At night, the ice weasels come."
                 -- Matt Groening
-----------------------------------------------------------------------

-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/
---------------------- multipart/mixed attachment
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 994 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/a80a1804/attachment.bin

---------------------- multipart/mixed attachment--