[dev] Re: [cvs] commit: horde/lib/MIME Part.php

[Jan Schneider]

Zitat von Jon Parise <jon@horde.org>:

> On Thu, Dec 19, 2002 at 03:02:41PM +0100, Jan Schneider wrote:
> 
> > > There are a lot of whitespace changes in that diff.  Could you please
> > > go back and correct them?  Or if they were intended, please make a
> > > note of them in future commits.
> >
> > We always used to fix ws when we touch a file for any reasons, but
> stating
> > that explicitely might be good idea.
> 
> Right.  I'm not complaining about the mixed goals of the commit.  It
> just explains why there are changed lines throughout the file if the
> log entry notes "and whitespace normalization".
> 
> Personally, I prefer style-related changes be made as separate
> commits, however.

Me too, but my editor strips trailing ws automatically and I actually told
it to do so after your "mass whitespace commits" a year or so ago. ;-)

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft