[dev] Re: [cvs] commit: horde setup.php horde/lib Setup.php horde/lib/Setup cli.php

[Chuck Hagenbuch]

Quoting Marko Djukic <marko at oblo.com>:

> - i'd prefer the scripts/setup.php phased out entirely, since with this
> new script i've managed to cover all its functionality and more. plus the
> new setup.php is not simply run-and-forget type of script, but interactive
> to the point that i want to get it to be fully menu based. and i'm trying
> to get it to be runnable either through the CLI or the browser (minus the
> security vulnerable parts). so i don't see it as belonging into scripts/.

I think the CLI frontend does. The scheme you have right now seems to have
an awful lot of logic and UI buried deep in the libraries; I think there
should be a script in admin/ for the web UI and a script in scripts/ for
CLI.

In the meantime, there is now quite a mess, with two different class trees
in horde/lib and three setup.php scripts. I would really appreciate it if
you would try to work with existing code more when you add major things
like this; the same thing came up with lib/Tree.php, which is still out of
sync with lib/CategoryTree.php.

> - i'm trying at the moment to update the script to take on the
> functionality of admin/setup.php too. so i suppose it could end up
> replacing it this script in the admin/ dir?

I think a web interface certainly belongs in admin/, and it needs to honor
Horde admin checks. I strongly feel that we should *not* have an
all-purpose setup script sitting in the main horde/ dir; users *must* have
to take a specific action to be able to execute a setup without
authentication through the web.

> - as for lib/Config.php i'd leave it as a separate file, but would like
> to get it CLI functional as well - i'm playing with getting some
> horde_form type of functionality in CLI.

That's great, but it's an entirely seperate issue. If you want to standardiz
 on lib/Setup, I can see that, but then shouldn't Config.php become
Setup_Configuration, or some such, since it performs specific setup tasks?

It is really important that our class tree stay coherent and not scatter all
over the place.

-chuck

--
Charles Hagenbuch, <chuck at horde.org>
"... It is not more light we need, but more warmth! We die of cold, not of
darkness. It is not the night that kills, but the frost." - Miguel de
Unamuno