[dev] Horde Metar Block

[Marcus I. Ryan]

Some cleanup and committed.  Thanks!  I've been anxious for this for a while.

As for comments:
Looking at it more closely, and Jan will correct me if I'm wrong, you gettext
strings that include markup.  I would think we wouldn't want to do that
because then if we change the markup, even if the value doesn't change, it
has to be retranslated.  I've fixed the major ones I saw, but there are more
that need it.

--
Marcus I. Ryan, marcus at horde.org
-----------------------------------------------------------------------
 "Love is a snowmobile racing across the tundra and then suddenly it
 flips over, pinning you underneath.  At night, the ice weasels come."
                 -- Matt Groening
-----------------------------------------------------------------------


Quoting Rick Emery <rick at emery.homelinux.net>:

> Quoting "Marcus I. Ryan" <marcus at horde.org>:
>
> > I just skimmed, but it looks good except:
> > * You shouldn't have to build a DSN to the DB connect call; just pass it
> > $conf['sql'].
>
> This is beautiful! Exactly the kind of feedback I was hoping for! I've made
> this
> change in the version attached.
>
> > * The html might get nudged a little (I'm not sure about multiple <br />
> tags
> > to get multiple line breaks) but other than that, looks good.
>
> I've modified the code a little, to use a <p /> tag instead of <br /> tags.
>
> Feel free to make any changes you feel are fitting. I don't claim to be
> anything
> but a beginning php coder.
>
> Thanks,
> Rick
>
> --
> Rick Emery
>
> "When once you have tasted flight, you will forever walk the Earth
>  with your eyes turned skyward, for there you have been, and there
>  you will always long to return"
>                                               -- Leonardo Da Vinci


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.