[dev] Re: [cvs] commit: mimp mailbox.php

Jan Schneider jan at horde.org
Tue Sep 21 08:56:14 PDT 2004


Zitat von Michael M Slusarz <slusarz at bigworm.curecanti.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at curecanti.org>:
>>
>>> slusarz     2004-09-20 22:32:49 PDT
>>>
>>>   Modified files:
>>>     .                    mailbox.php
>>>   Log:
>>>   $sort_url not used here.
>>>   More addParameter fixes to make sure & is not encoded.  IMHO, the new
>>>   addParameter() syntax seems to break a lot more stuff than it is
>>>   supposed to fix.
>>
>> I'm not sure why you need so many changes in MIMP. Unencoded parameter
>> separators should only be necessary in redirects or javascript. Oh, and
if
>> you call Horde::url() *after* the addParameter() calls, you only need to
>> specify the $full parameter once.
>
> Except that '&amp' encoded parameter separators break everything for
> me.  i.e.:
> http://www.example.com/horde/test.php?foo1=foo&amp;foo2=fee
>
> does *not* work the same as:
> http://www.example.com/horde/test.php?foo1=foo&foo2=fee
>
> In the first example, 'foo2' doesn't exist when you try to access it in
> test.php
> - i.e. a call of Util::getFormData('foo2') returns null.  It works
> fine in the
> second example - a call to Util::getFormData('foo2') returns 'fee'.
>
> In both cases, this isn't a redirect or javascript link either - it is
> a simple
> link you click on the page.

Then something is really broken on your side. Every brower translates &amp;
to & in HTML code, this also effects links. When clicking such a link the
request contains correctly & as the separator. Anything else is badly
broken.

Jan.

--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/


More information about the dev mailing list