[dev] Turba History broken?

Karsten Fourmont fourmont at gmx.de
Tue Nov 30 02:42:39 PST 2004


Hi,

I noticed that the format of UIDs changed from something like
tuba:localsql:1aad1e54af02108adf9088543f7248b7

to

20041130112355.2kw5umr3si80 at voltaire.local

the change from a hex value to a mail like id is fine, but now the 
leading tuba:source stuff is missing. Particular in lib/Driver.php line 431:

$history->log($uid, array('action' => 'add'), true);

adds the plain uid, without turba:localsql. As a result the entry is put 
into the datatree without a parent and thus is basically useless.
Consequently a call to

$registry->call('contacts/listBy', array('action' => 'add', 'timestamp' 
=> 0));

will not retrieve it.

Is the lack of 'turba:localsql:' by design or has just forgotten here?

I propose a change to s.th like

$history->log('turba:' . $this->name . ':' . $uid,
               array('action' => 'add'), true);

Is this OK?

  Cheers,
    Karsten




More information about the dev mailing list