[dev] Turba History broken?

[Chuck Hagenbuch]

Quoting Karsten Fourmont <fourmont at gmx.de>:

> the change from a hex value to a mail like id is fine, but now the
> leading tuba:source stuff is missing. Particular in lib/Driver.php line 431:
>
> $history->log($uid, array('action' => 'add'), true);
>
> adds the plain uid, without turba:localsql. As a result the entry is put
> into the datatree without a parent and thus is basically useless.
> Consequently a call to
>
> $registry->call('contacts/listBy', array('action' => 'add', 'timestamp'
> => 0));
>
> will not retrieve it.
>
> Is the lack of 'turba:localsql:' by design or has just forgotten here?

By design, but you're correct that turba: should still be there.

> I propose a change to s.th like
>
> $history->log('turba:' . $this->name . ':' . $uid,
>                array('action' => 'add'), true);

$this->name needs to be left out.

Try what I'm committing now.

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams