[dev] [cvs] commit: incubator/beatnik editrec.php viewzone.php incubator/beatnik/lib Beatnik.php api.php base.php incubator/beatnik/templates common-header.inc editrec.inc menu.inc viewzone.inc incubator/beatnik/templates/edit edit.inc ...

[Ben Klang]

On Aug 5, 2006, at 12:04 PM, Duck wrote:

> On Saturday 05 August 2006 17:16, Ben Klang wrote:
>> Why did you move $beatnik->getDomains() into menu.inc?  Also, it
>> needs to be checked for returning PEAR::Error class.
>
> It was already  in the menu. The difference is just the GLOBALS  
> usage becouse
> we now do not set the global var and then reference it to $beatnik  
> but just
> use the global one. And again the getDomains functions itself must  
> be changed
> to handle permissions not just errors.
Mea culpa.  I agree that it needs to be extended to check  
permissions.  I think it more properly belongs in base.php as almost  
every page afterward expects to have it available.  Regardless I  
don't think a .inc file is the place for it to be.  I'll go move it  
and add the return error check.

/BAK/
>
> Duck
>
> -- 
> Horde developers mailing list - Join the hunt: http://horde.org/ 
> bounties/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org

-- 
Ben Klang
Alkaloid Networks
ben at alkaloid.net
404.475.4850
http://projects.alkaloid.net