[dev] [cvs] commit: imp/lib/IMAP MailboxCache.php

Michael M Slusarz slusarz at horde.org
Fri Mar 9 04:34:58 UTC 2007


Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>> If that's the case, I have no issues with requiring string data.
>> Obviously, this would be a BC breaking API change
>
> I'm not sure it would, actually - maybe technically, but given that no
> backends except file and zps exist in release code, and most people
> don't use zps, I'm pretty sure we were always passing string data
> before.
>
>> However other drivers may be doing their own serialization techniques
>> on given data, so it is quite possible that we would be doing totally
>> inefficient double serialization for all other drivers.
>
> Well, I think that should just push us to not serialize things when we
> don't have to. ;)

All right - given the argument that we aren't passing $data as  
anything else but a string right now, I have backed out my  
serialization changes.  Will make a TODO to change this for 4.0.  BTW,  
backing out the changes seems to have also fixed the class not defined  
errors in IMP.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list