[dev] [commits] Horde branch master updated. 793c96d68d8efdb94f3184b9a67ae3f03ddda755

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>
>>>> The branch "master" has been updated.
>>>> The following is a summary of the commits.
>>>>
>>>> from: fbac4359f7c5f4b12dcf330dabc7228e1aa64762
>>>>
>>>> c6ee180 Remove unneeded autoload includes
>>>
>>> Unless I'm missing something, they are (or at least were at some  
>>> point) necessary to run individual unit test, opposed to a  
>>> complete test suite for a library.
>>
>> I've never personally assumed that we would run tests separately  
>> (any tests I have written won't work this way).
>>
>> It would be a real PITA to have to include the Autoload library in  
>> every single individual unit test.  The harder it is to create a  
>> unit test, the less motivation there is to create such tests.  If  
>> this is really a requirement, I personally will condense all  
>> UnitTests into a single file so I don't have to deal with this kind  
>> of overhead crap.
>
> How is copy and pasting a single line overhead crap? I run the full  
> suites 99% of the time too, but the larger the suites get, and the  
> more often you only need a single test out of the suite for tracking  
> down a bug, the more annoying it is if you have to wait a minutes  
> for each test run. I do this only once in a few months but then it  
> comes handy.

It's crap because each package is requiring maintenance of a unique  
AllTests.php (and possibly Autoload.php) before a single test can be  
run.  Our test system is already complex enough (I have **never**  
received a failing test case from a non-dev) that we don't need to add  
more complexity.

It seems to me like that AllTests.php is not needed (phpunit * will  
work) and Autoload.php can be worked around by defining a phpunit.xml  
file in every test directory that points to a bootstrap file in  
Horde_Test.

> And a unit test purist will of course tell you that it's a key point  
> to be able to run individual small tests, but I won't, and please  
> don't take a too close look at my Horde_Group or Horde_Share tests.

It is much more important to me to know **which** test is failing, not  
the category of test the package maintainer has placed it in.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]