[dev] Re: [horde] problem with attachments , log file and segfaults

[René Lund Jensen]

Did these patches slip the developers eyes..?

I for one think they are great..
just patched my RELENG version (manually, the patch failed), works fine.
One improvement could be to withdraw the attched files size from the 
total and then display whats left.

I'm not stepping up to do the work as I'm in the middel of my examns.

René Jensen

Serge Grondin wrote:
> Eric Rostetter a écrit :
> 
>>Quoting sysadmin at intergold.net:
>>
>>
>>>>Sounds like it probably isn't a php issue, but could also be that squirrel
>>>>mail changes the limit on the fly?  (Don't know, never used squirrel mail).
>>>
>>>Any changes made to the upload_max_filesize in php.ini is reflected in the
>>>compose window of the squirrel mail (It shows the max size that can be
>>>attached) , so it must be taking the value from php.ini.
>>
>>Hey!  That's a great idea.  Anyone want to add this to the IMP compose
>>window?  It would prevent a lot of user questions as well as help the
>>admins trouble shoot attachment upload problems.
>>
> 
> 
> Here is a little patch to do just that.
> 
> For the IMP RELENG version
> 
> # cvs diff -u compose.inc
> Index: compose.inc
> ===================================================================
> RCS file: /repository/imp/templates/compose/compose.inc,v
> retrieving revision 2.123.2.25
> diff -u -r2.123.2.25 compose.inc
> --- compose.inc 27 Mar 2003 17:08:35 -0000      2.123.2.25
> +++ compose.inc 23 May 2003 19:36:30 -0000
> @@ -397,7 +397,7 @@
>  <tr><td colspan="2">&nbsp;</td></tr>
>  <tr class="header">
>      <td colspan="2" height="25" class="header">
> -        <b>&nbsp;<a name="attachments"></a><?php echo _("Attachments")
> ?></b>
> +        <b>&nbsp;<a name="attachments"></a><?php echo
> sprintf(_("Attachments of maximum size of %s"),
> ini_get('upload_max_filesize')) ?></b>
>      </td>
>  </tr>
> 
> 
> For the IMP HEAD version
> 
> # cvs diff -u compose.inc
> Index: compose.inc
> ===================================================================
> RCS file: /repository/imp/templates/compose/compose.inc,v
> retrieving revision 2.228
> diff -u -r2.228 compose.inc
> --- compose.inc 21 May 2003 01:07:28 -0000      2.228
> +++ compose.inc 23 May 2003 19:55:13 -0000
> @@ -514,7 +514,7 @@
>  <tr><td colspan="2">&nbsp;</td></tr>
>  <tr class="header">
>      <td colspan="2" height="25" class="header">
> -        <b>&nbsp;<a name="attachments"></a><?php echo _("Attachments")
> ?></b>
> +        <b>&nbsp;<a name="attachments"></a><?php echo
> sprintf(_("Attachments of maximum size of %s"),
> ini_get('upload_max_filesize')) ?></b>
>      </td>
>  </tr>
> 
>