[horde] Install Horde from Git

[Jonathan Rogers]

On Fri, 26 Mar 2010 14:42:01 -0600, Michael M Slusarz <slusarz at horde.org>
wrote:
> Quoting Jonathan Rogers <jonathan at findyourfans.com>:
> 
>> The only line like that in my horde/config/conf.php is the one at the
>> very
>> end, after the "YOU SHOULDN'T CHANGE ANTHING BELOW THIS LINE." line. I
>> started with "$conf['log']['enabled'] = false;" from the conf.php.dist.
I
>> just changed it to true, but that doesn't seem to have any effect on
>> anything.
> 
> Are you absolutely sure you are using the most up to date git version?  
>   There have been a bunch of fixes this week for precisely this issue  
> - namely errors that occur during the initialization process (they are  
> tricky to report, since the error reporting framework is not yet fully  
> initialized - classic chicken and egg issue).

I eventually tracked down the "Bad log level" problem to the Horde class
in "framework/Core/lib/Horde.php" where the logMessage method was passing
Horde_Log_Logger::log a $priority string instead of the integer $level it
expected. It looks like a bug to me, but I'm not sure exactly where it
should be fixed. The simplest way seemed to me just fix it right there:
------------------------------------------------------------------------
diff --git a/framework/Core/lib/Horde.php b/framework/Core/lib/Horde.php
index 169f5fa..d52a261 100644
--- a/framework/Core/lib/Horde.php
+++ b/framework/Core/lib/Horde.php
@@ -65,7 +65,9 @@ class Horde
                                       array $options = array())
     {
         $options['trace'] = 2;
-       
$GLOBALS['injector']->getInstance('Horde_Log_Logger')->log($event,
$priority, $options);
+       //       
$GLOBALS['injector']->getInstance('Horde_Log_Logger')->log($event,
$priority, $options);
+
+      
call_user_func(array($GLOBALS['injector']->getInstance('Horde_Log_Logger'),$priority),$event);
     }
 
     /**
------------------------------------------------------------------------

---------------------
Jonathan Rogers