[imp] select all/none dropdown in CVS HEAD

Rob Siklos rob2 at siklos.ca
Wed Jun 18 07:32:26 PDT 2003


----- Original Message ----- 
From: "Chuck Hagenbuch" <chuck at horde.org>
To: <imp at lists.horde.org>
Sent: Wednesday, April 23, 2003 1:42 PM
Subject: Re: [imp] select all/none dropdown in CVS HEAD


> Quoting Rob Siklos <rob2 at siklos.ca>:
>
> > Ok, so forget removing the dropdown, what about implementing a real
> > checkbox at the column header?
>
> Patch?
>
> -chuck
>

Here's the patches (on HEAD) to turn the image of the checkbox in the table
header of the message list view into a working select all/none checkbox.  I
think this is a useful feature.


[/home/rob/www/horde/imp/templates/mailbox/]$ cvs diff message_headers.inc
Index: message_headers.inc
===================================================================
RCS file: /repository/imp/templates/mailbox/message_headers.inc,v
retrieving revision 2.58
diff -r2.58 message_headers.inc
65c65
<     <th align="left" nowrap="nowrap" width="8%">&nbsp;<?php echo
Horde::img('checkbox.gif', _("Checkbox")) ?></th>
---
>     <th align="left" nowrap="nowrap" width="8%"><input type="checkbox"
name="checkAll" onclick="makeSelection(-1);" /></th>

###############################################

[/home/rob/www/horde/imp/templates/mailbox/]$ cvs diff javascript.inc
Index: javascript.inc
===================================================================
RCS file: /repository/imp/templates/mailbox/javascript.inc,v
retrieving revision 2.50
diff -r2.50 javascript.inc
45c45,46
<     if (whichForm == 1) {
---
>     switch (parseInt(whichForm)) {
>     case 1:
47c48,56
<     } else {
---
>         break;
>     case -1:
>         if (document.messages.checkAll.checked) {
>             flag = "!<?php echo IMP_ALL ?>";
>         } else {
>             flag = "<?php echo IMP_ALL ?>";
>         }
>         break;
>     default:
60c69,71
<     if (whichForm == 1) {
---
>
>     switch (parseInt(whichForm)) {
>     case 1:
62c73,76
<     } else {
---
>         break;
>     case -1:
>         break;
>     default:




More information about the imp mailing list