[sork] LDAP ?

[Eric Rostetter]

Quoting Diego Rivera <lrivera@racsa.co.cr>:

> I think it is...that's enough for me!  ;)  Seriously, the improvements
> I've done are more in the area of implementation than anything else.

It is enough for you, indeed, and should be.  But not enough to get
it to replace the existing modules ;)
 
> The modularity is now much closer to be pluggable, since there's a
> parent class that's used to set the options, and a subclass to do the
> actual work (only FTP available so far, others possible...).

We already have this functionality in sork. (with multiple backends)

> > > It's more modular than before - i.e., it abstracts the FTP to a point,
> > > but this abstraction could be improved (working on it now).
> >
> > You'd have to show how this is better than the current system.
> 
> The current system assumes everything is on FTP, and in a particular FTP
> layout on top of that.


No, it doesn't.  Your current view is pretty old/obsolete.

The current versions allow you to select backends (ftp, sql, mdeaemon, etc).

> Granted, I've not seen CVS_HEAD, but the last
> time I did (a month or so ago) it didn't seem to have moved much from
> the released "2.0" version of these packages.

I'll admit it is going slow.  The major changes happen in passwd first
and then filter down through forwards and vacation.

But there was already a 2.1 release, so I wouldn't work off the 2.0 release
if I was you!
 
> The improvement is in abstracting the actual implementation layer.

Already been/being done in sork.

> Bear in mind although I'm not a newbie programmer, I AM a PHP newbie, so
> I may be overlooking some of the languages features/limitations with my
> implementation.  I'll let you guys decide how my alcohol intake has
> affected my programmig skills over time... ;)

You work sounds good, but it looks like you are re-inventing the wheel
for the most part.  The release versions already have multiple backend
support, and the HEAD versions are going to an even better system.

The main thing you have new is the combining of the two modules, which has
been discussed/considered before.  In fact, we've considered combining sork
with other modules also.  And we're considering api modules so you can call
different modules from IMP or elsewhere.  But so far, no concrete work into
any of this.

> > > I'll e-mail you guys a copy later, and I'm also considering submitting
> > > this into Horde for replacement of both projects.
> >
> > Sure, send it to the sork list and we'll check it out.  If it is better,
> > then there is no reason not to replace it.
> 
> Here it is.

I'll look at it when I get a chance.  Thanks!

> > There has been much talk about this, but no real work.  The changes
> > are really very trivial (which makes me wonder why I never did it
> > before).
> 
> The screen is there - single screen.  It is limited to only one
> forwarding address, though.

Would like to have more flexibility here, as well as adding alias support.
(Started on that, but never finished)

> I also added the "api.php" file to show a brief status when the main
> horde screen is shown (i.e., forward active, vacation active, etc.).

Way cool!  Now that I would definately like to see!  (If not for the
horde summary screen, then for my accounts module).

> Anyway, look it over and send me your comments.  I'd really like to know
> how good (bad?) my PHP is coming from someone who's been doing a lot
> more of it than I.

Any problems with me stealing code (like the api code) from you?  I'd of
course give you credit. :)  From what you said, even if I don't like your
module as a whole, there are probably some code sections I'd really want
to steal from it.

> Best
> 
> Diego

-- 
Eric Rostetter
The Department of Physics
The University of Texas at Austin

Why get even? Get odd!